RFR: 8371083: FollowReferences reports non-class objects as JVMTI_HEAP_REFERENCE_SYSTEM_CLASS [v2]

Alex Menkov amenkov at openjdk.org
Thu Nov 13 19:46:33 UTC 2025


On Wed, 12 Nov 2025 23:32:29 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   feedback
>
> src/hotspot/share/prims/jvmtiTagMap.cpp line 2193:
> 
>> 2191: };
>> 2192: 
>> 2193: // A supporting closure used to process ClassLoaderData roots
> 
> Nit: Need dot at the end of comment.

Fixed

> test/hotspot/jtreg/serviceability/jvmti/FollowReferences/KindSystemClass/libKindSystemClass.cpp line 79:
> 
>> 77: 
>> 78:   for (int i = 0; i < class_counter; i++) {
>> 79:     tags[i] = i+1;
> 
> Nit: Need spaces around `+` sign.

Fixed.

> test/hotspot/jtreg/serviceability/jvmti/FollowReferences/KindSystemClass/libKindSystemClass.cpp line 101:
> 
>> 99: }
>> 100: 
>> 101: 
> 
> Nit: Unneeded extra empty line.

removed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28224#discussion_r2524717090
PR Review Comment: https://git.openjdk.org/jdk/pull/28224#discussion_r2524716711
PR Review Comment: https://git.openjdk.org/jdk/pull/28224#discussion_r2524717427


More information about the hotspot-dev mailing list