RFR: 8371458: [REDO] Remove exception handler stub code in C2 [v2]

Ruben duke at openjdk.org
Thu Nov 13 23:49:29 UTC 2025


On Mon, 10 Nov 2025 10:50:13 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Ruben has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add an assertion to detect out of bounds access in post-call NOP checks
>
> src/hotspot/cpu/x86/nativeInst_x86.hpp line 585:
> 
>> 583:   };
>> 584: 
>> 585:   bool check() const { return short_at(0) == 0x1f0f && short_at(2) == 0x0084; }
> 
> Maybe a comment would be nice.

Thanks for the suggestion. Would the comments added at https://github.com/openjdk/jdk/pull/28192/commits/20cc58a3649db0650da054809f64e0c4416d616f be suitable?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28192#discussion_r2525276626


More information about the hotspot-dev mailing list