RFR: 8357551: RISC-V: support CMoveF/D vectorization [v3]

Hamlin Li mli at openjdk.org
Mon Nov 17 13:42:20 UTC 2025


On Mon, 17 Nov 2025 07:43:02 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Good idea!
>> I can do it. What do you think about the name of the merged tests? `TestConditionalMove.java` or `TestScalarAndVectorConditionalMove.java`
>
> `TestConditionalMove.java` sounds good :)
> 
> It would also be nice if we could move it out of the `irTests` directory, we would like to eventually move all tests away from it, and rather sort the tests by what they test and not by how we test them. Though now it's a little tricky because we check for both vector and scalar things. Still, I would propose that you move it under `c2/vectorization` or `c2/loopopts/superword`, since they do include vectorization tests. An alternative could also be in a new `c2/cmove` directory.

I can do the move for this specific file at the last commit of this pr. Or we can move a bunch of tests (some other tests under irTests) in a separate pr, as there are `Asserts` in other tests under `irTests`. I prefer the latter one, as it put related changes in one specific pr. Plesae let me know how you think about it. :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28309#discussion_r2534108304


More information about the hotspot-dev mailing list