RFR: 8371923: Update LockFreeStack for Atomic<T> [v2]

Kim Barrett kbarrett at openjdk.org
Tue Nov 18 10:48:59 UTC 2025


On Tue, 18 Nov 2025 09:15:48 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into lock-free-stack-allows-new-atomic
>>  - rename next_access to next_accessor
>>  - LockFreeStack supports Atomic<T>
>
> src/hotspot/share/utilities/lockFreeStack.hpp line 59:
> 
>> 57: // \tparam T is the class of the elements in the stack.
>> 58: //
>> 59: // \tparam next_access is a function pointer.  Applying this function to
> 
> Maybe `next_accessor`? I found reading `next_access` difficult because it’s unclear whether it’s meant as a verb (i.e., “access next”) or a noun (i.e., “next access”).

That's a fair point.  Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28329#discussion_r2537486877


More information about the hotspot-dev mailing list