RFR: 8366671: Refactor Thread::SpinAcquire and Thread::SpinRelease [v4]
Anton Artemov
aartemov at openjdk.org
Wed Nov 19 14:10:14 UTC 2025
On Mon, 17 Nov 2025 22:10:53 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> For the same reason why `jfrSpinlockHelper.hpp` was included.
>>
>> It looks like the two includes above that are redundant and can be removed. This one cannot, it breaks builds.
>
> Include of "atomicAccess.hpp" seems unnecessary, as there are no (direct) uses here.
> "globalDefinitions.hpp" should not be removed, under the "Include What You Use" guidance
> (which hasn't yet made it into the Style Guide - https://bugs.openjdk.org/browse/JDK-8252896).
I removed "atomicAccess.hpp".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28264#discussion_r2542147468
More information about the hotspot-dev
mailing list