RFR: 8367656: Refactor Constantpool's operand array into two [v16]

Johan Sjölen jsjolen at openjdk.org
Wed Nov 19 14:28:37 UTC 2025


On Wed, 5 Nov 2025 12:42:01 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 31 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'openjdk/master' into operands-again
>>  - It's fine to initialize the iterator with null, it's not fine to reserve an entry if it's null
>>  - Fix naming
>>  - Serguei comments
>>  - Revert change
>>  - Some nits
>>  - Fix copyright
>>  - Move BSMAttribute BSMAttributeEntries to own header file
>>  - Merge remote-tracking branch 'origin/operands-again' into operands-again
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
>>  - ... and 21 more: https://git.openjdk.org/jdk/compare/c1908450...57f0093e
>
> src/hotspot/share/oops/bsmAttribute.hpp line 28:
> 
>> 26: #define SHARE_OOPS_BSMATTRIBUTE_HPP
>> 27: 
>> 28: #include "classfile/classLoaderData.hpp"
> 
> I think you can forward declare ClassLoaderData rather than include the whole file here.

Ooh, you're right about that!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27198#discussion_r2542245468


More information about the hotspot-dev mailing list