RFR: 8366671: Refactor Thread::SpinAcquire and Thread::SpinRelease [v7]

David Holmes dholmes at openjdk.org
Thu Nov 20 06:20:14 UTC 2025


On Wed, 19 Nov 2025 20:34:18 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8366671: Addressed reviewer's comments
>
> src/hotspot/share/utilities/spinCriticalSection.hpp line 30:
> 
>> 28: #include "runtime/javaThread.hpp"
>> 29: 
>> 30: class SpinCriticalSectionHelper : AllStatic {
> 
> SpinCriticalSectionHelper is only used (and only usable by)
> SpinCriticalSection. There doesn't seem to be any benefit to the separation
> now.

I agree.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28264#discussion_r2544485815


More information about the hotspot-dev mailing list