RFR: 8366671: Refactor Thread::SpinAcquire and Thread::SpinRelease [v7]

[Anton Artemov]

On Thu, 20 Nov 2025 06:13:44 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8366671: Addressed reviewer's comments
>
> src/hotspot/share/utilities/spinCriticalSection.cpp line 34:
> 
>> 32:   }
>> 33: 
>> 34:   SpinYield sy(4096, 5, 1000000);
> 
> This is supposed to be a refactor. If you want to change the implementation then I suggest a separate PR with full performance analysis.

Well, I was not actually aware of `SpinYield` existence before @kimbarrett pointed at it. Agree, let's do it in a separate PR. Rolled back.

> src/hotspot/share/utilities/spinCriticalSection.hpp line 33:
> 
>> 31:   friend class SpinCriticalSection;
>> 32:   template<class Lambda, class...Args>
>> 33:   friend class SpinSingleSection;
> 
> Shouldn't this be removed?

Removed with the whole helper class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28264#discussion_r2545364628
PR Review Comment: https://git.openjdk.org/jdk/pull/28264#discussion_r2545365262