RFR: 8366671: Refactor Thread::SpinAcquire and Thread::SpinRelease [v8]
David Holmes
dholmes at openjdk.org
Thu Nov 20 11:52:56 UTC 2025
On Thu, 20 Nov 2025 10:37:21 GMT, Anton Artemov <aartemov at openjdk.org> wrote:
>> Hi,
>>
>> please consider the following changes:
>>
>> In this PR `Thread::SpinAcquire()` and `Thread::SpinRelease()` methods are refactored into a utility class `SpinCriticalSection`. The motivation is to make it easier for developers to use this lightweight synchronization mechanism in the codebase. The two aforementioned methods were used in JFR to create short critical sections with a helper class, but that was not the case for the object monitor code.
>>
>> Tested in tiers 1 - 5.
>
> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>
> 8366671: Addressed reviewers' comments.
I think this is okay now. Thanks
For some reason git now considers the new file to be a rename of the old file - which messes up the view.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28264#pullrequestreview-3487403904
More information about the hotspot-dev
mailing list