RFR: 8372248: GTest istream.coverage depends on istream.basic [v2]
Axel Boldt-Christmas
aboldtch at openjdk.org
Thu Nov 20 13:17:29 UTC 2025
> These two GTests have a strong dependency that `istream.coverage` is ran after `istream.basic`. This goes against the intended design of GTests. (They should be independent).
>
> As such I propose we merge this into one test.
>
> I kept the two `VERBOSE` variables separate. However I am not sure I understand their purpose.
> Currently changing `VERBOSE_TEST` to `true` will cause the test to fail, (not all cases are covered). And the value have of `VERBOSE_COVERAGE` has no effect. What is observed:
> * `(VERBOSE_TEST: false, VERBOSE_COVERAGE: false) -> Success`
> * `(VERBOSE_TEST: false, VERBOSE_COVERAGE: true) -> Success`
> * `(VERBOSE_TEST: true, VERBOSE_COVERAGE: false) -> Failure`
> * `(VERBOSE_TEST: true, VERBOSE_COVERAGE: true) -> Failure`
>
> But I kept the original behaviour, just merged into one test case rather than two.
Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
- Merge branch 'JDK-8372241' into JDK-8372248
- gtest istream.coverage depends on istream.basic
-------------
Changes: https://git.openjdk.org/jdk/pull/28418/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28418&range=01
Stats: 9 lines in 2 files changed: 0 ins; 5 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/28418.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28418/head:pull/28418
PR: https://git.openjdk.org/jdk/pull/28418
More information about the hotspot-dev
mailing list