RFR: 8357445: G1: Time-Based Heap Uncommit During Idle Periods [v7]

Thomas Schatzl tschatzl at openjdk.org
Thu Nov 20 15:09:04 UTC 2025


On Wed, 27 Aug 2025 11:59:26 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1HeapRegion.hpp line 257:
>> 
>>> 255:   uint _node_index;
>>> 256: 
>>> 257:   // Time-based heap sizing: tracks last allocation/access time
>> 
>> Suggestion:
>> 
>>   // Time-based heap sizing: tracks last allocation/access time.
>
> The comment is wrong/outdated too, only tracks last freeing (clearing) time. Maybe there is a better name than `_last_access_time` for the member too.

Still an issue...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26240#discussion_r2546141588


More information about the hotspot-dev mailing list