RFR: 8352567: [s390x] disable JFR tests requiring JFR stubs
Vladimir Petko
vpetko at openjdk.org
Tue Nov 25 20:04:19 UTC 2025
On Fri, 21 Nov 2025 01:48:27 GMT, Vladimir Petko <vpetko at openjdk.org> wrote:
> JFR stubs are not [implemented](https://github.com/openjdk/jdk/blame/06ba6cf3a137a6cdf572a876a46d18e51c248451/src/hotspot/cpu/s390/sharedRuntime_s390.cpp#L3412).
> Add platform requirement to JFR tests that require JFR stubs to skip them on S390x.
>
> Testing:
> - s390x:
>
> ==============================
> Test summary
> ==============================
> TEST TOTAL PASS FAIL ERROR SKIP
> jtreg:test/hotspot/jtreg/applications/ctw/modules/jdk_jfr.java
> 0 0 0 0 0
> jtreg:test/hotspot/jtreg/compiler/intrinsics/TestReturnOopSetForJFRWriteCheckpoint.java
> 0 0 0 0 0
> jtreg:test/jdk/jdk/jfr 630 577 0 0 53
> ==============================
> TEST SUCCESS
>
>
> - amd64:
>
> ==============================
> Test summary
> ==============================
> TEST TOTAL PASS FAIL ERROR SKIP
> jtreg:test/hotspot/jtreg/applications/ctw/modules/jdk_jfr.java
> 1 1 0 0 0
> jtreg:test/hotspot/jtreg/compiler/intrinsics/TestReturnOopSetForJFRWriteCheckpoint.java
> 1 1 0 0 0
> jtreg:test/jdk/jdk/jfr 629 622 0 0 7
> ==============================
> TEST SUCCESS
> I would've suggested to use `@requires vm.continuations` that way test will be disabled if continuations support is not there. Or probably we can do simple problem listing, that way it will be little easy to enable the test case again.
> ...
> But it seems once these stubs were implemented for other architectures the requirement for continuations support vanished. See aarch64 for example:
Yes, probably problemlist is a good alternative - could you please provide a bug number that I should use?
I did not do `@requires vm.continuations` since you *can* enable the feature on s390x, but since it is not implemented it will be crashing in the tests.
> I see this testcase failing in tier1 tests on headstream: java/foreign/sharedclosejfr/TestSharedCloseJFR.java could you check if it's the same case for you as well ?
Absolutely! I will update PR or raise an issue if it is a separate reason
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28444#issuecomment-3577371150
More information about the hotspot-dev
mailing list