RFR: 8357258: x86: Improve receiver type profiling reliability [v3]

Aleksey Shipilev shade at openjdk.org
Wed Nov 26 13:49:33 UTC 2025


On Thu, 20 Nov 2025 17:10:33 GMT, John R Rose <jrose at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Merge branch 'master' into JDK-8357258-x86-c1-optimize-virt-calls
>>  - Merge branch 'master' into JDK-8357258-x86-c1-optimize-virt-calls
>>  - Drop atomic counters
>>  - Initial version
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 4845:
> 
>> 4843:         push(temp_reg);
>> 4844:         movptr(temp_reg, recv);
>> 4845:         recv_reg = temp_reg;
> 
> I can mentally do the appropriate `assert_different_registers` here, but an explicit one to confirm would be better.
> (Same comment for the next arm of the if/else.)

https://github.com/openjdk/jdk/pull/25305#issuecomment-3581395413 :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25305#discussion_r2565073504


More information about the hotspot-dev mailing list