RFR: 8371259: ML-DSA AVX2 and AVX512 intrinsics and improvements [v3]
Volodymyr Paprotski
vpaprotski at openjdk.org
Wed Nov 26 16:52:03 UTC 2025
On Mon, 24 Nov 2025 21:00:39 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one additional commit since the last revision:
>>
>> next set of comments
>
> Marked as reviewed by ascarpino (Reviewer).
Oh.. realized that I should had checked JBS.. thanks @ascarpino for resolving the bug I caused! At least its just the option.. whew.
> @dholmes-ora Hi David, need some help with this please, don't have access to an ARM system to reproduce (or the ARM expertise).. could you point me at the failing job if thats available? Or some log if not?
>
> * Is it an issue with the options (i.e. `-XX:UseAVX=2` perhaps). I probably should had added `-XX:+IgnoreUnrecognizedVMOptions` to it..
> * Otherwise, I am stumped.. the test case isn't architecture-specific.. it calls two methods (one of which is annotated as an intrinsic..) and expects them to return the same value.. i.e. Java and Intrinsic version should behave the same..
> * Only thing I can think of.. The ARM implementation took some shortcuts in name of optimization. This can be entirely valid if the code calling the intrinsics never should get some specific value (-ranges). i.e. the tests RNG be further restricted..
> * Otherwise.. is it possible its a bug in the ARM intrinsic?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28136#issuecomment-3582226267
More information about the hotspot-dev
mailing list