RFR: 8354282: C2: more crashes in compiled code because of dependency on removed range check CastIIs [v4]

[Roland Westrelin]

On Wed, 26 Nov 2025 14:29:06 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> Introducing a 4th dependency type looks reasonable. It's also nice to see one more refactoring in that area which makes it very expressive now. Thanks for doing that! I left some suggestions to possibly further improve the code.

Thanks for the comments/suggestions. Updated change should take care of all of them.

> src/hotspot/share/opto/castnode.hpp line 101:
> 
>> 99:       }
>> 100:       return NonFloatingNonNarrowing;
>> 101:     }
> 
> Just a side note: We seem to mix the terms "(non-)pinned" with "(non-)floating" freely. Should we stick to just one? But maybe it's justified to use both depending on the situation/code context.

The patch as it is now adds some extra uses of "pinned" and "floating". What could make sense, I suppose, would be to try to use "floating"/"non floating" instead but there are so many uses of "pinned" in the code base already, and I don't see us getting rid of them, that I wonder if it would make a difference. So, I'm not too sure what to do.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24575#issuecomment-3585614507
PR Review Comment: https://git.openjdk.org/jdk/pull/24575#discussion_r2568439115