RFR: 8344116: C2: remove slice parameter from LoadNode::make [v13]

Zihao Lin duke at openjdk.org
Thu Nov 27 16:01:57 UTC 2025


On Thu, 27 Nov 2025 09:59:31 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Zihao Lin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix test failed
>
> src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp line 720:
> 
>> 718:     if (ShenandoahCardBarrier) {
>> 719:       post_barrier(kit, kit->control(), access.raw_access(), access.base(),
>> 720:                    access.addr(), access.alias_idx(), new_val, T_OBJECT, true);
> 
> `access.alias_idx()` should be `C->get_alias_index(kit.gvn().type(access.addr()))`
> 
> So I think we want to remove `uint  _alias_idx;` from `C2AtomicParseAccess` as well. This could be done as a follow up if you think this change has already gotten too complicated.

I think we can create another task focus on remove `alias_idx`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24258#discussion_r2569382908


More information about the hotspot-dev mailing list