RFR: 8372650: Convert GenericWaitBarrier to use Atomic<T>

Kim Barrett kbarrett at openjdk.org
Fri Nov 28 08:38:47 UTC 2025


On Thu, 27 Nov 2025 10:28:26 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Please review this change to GenericWaitBarrier to use Atomic rather than
>> directly applying AtomicAccess to volatile members.
>> 
>> Testing: mach5 tier1-5
>
> src/hotspot/share/utilities/waitBarrier_generic.cpp line 199:
> 
>> 197:     }
>> 198:   }
>> 199:   assert(_outstanding_wakeups.load_acquire() == 0, "Post disarm: Should not have outstanding wakeups");
> 
> Does not have to be `_acquire`, original load is relaxed.

Oops. Will fix.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28527#discussion_r2570824516


More information about the hotspot-dev mailing list