RFR: 8344116: C2: remove slice parameter from LoadNode::make [v13]
Zihao Lin
duke at openjdk.org
Sun Nov 30 08:05:52 UTC 2025
On Fri, 28 Nov 2025 14:51:49 GMT, Roland Westrelin <roland at openjdk.org> wrote:
>> The assert failed because `find_inst_mem()` skipped an Initialize memory projection whose `adr_type` was still the general slice, then tried to fetch the instance-specific projection from `_node_map` and got nullptr. That happens when a precise `NarrowMemProj` already exists: the code doesn’t create a new one and also never records the mapping, so later lookup fails.
>>
>> The fix records the mapping even if the precise `NarrowMemProj` is already present (not newly created).
>
> I had a closer look and I think you ran into an inconsistency. Let me see if I can get it fixed as a separate change.
Sure, it's better to separate to another change. I am not familiar this part, please pin me if you have better solution. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24258#discussion_r2573499061
More information about the hotspot-dev
mailing list