RFR: 8360389: Support printing from C2 compiled code [v11]

Benoît Maillard bmaillard at openjdk.org
Wed Oct 1 08:25:12 UTC 2025


On Tue, 30 Sep 2025 07:45:28 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove implicit null check
>
> src/hotspot/share/opto/compile.cpp line 5444:
> 
>> 5442:   Node* str_node = gvn->transform(new ConPNode(TypeRawPtr::make(((address) str))));
>> 5443:   const TypeFunc* type = OptoRuntime::debug_print_Type(parm0, parm1, parm2, parm3, parm4, parm5, parm6);
>> 5444:   Node *call = new CallLeafNode(type, call_addr, "debug_print", TypeRawPtr::BOTTOM);
> 
> Suggestion:
> 
>   Node* call = new CallLeafNode(type, call_addr, "debug_print", TypeRawPtr::BOTTOM);

Good catch

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26475#discussion_r2393810107


More information about the hotspot-dev mailing list