RFR: 8364929: Assign unique id to each AdapterBlob stored in AOTCodeCache [v3]

Ashutosh Mehra asmehra at openjdk.org
Thu Oct 2 18:52:14 UTC 2025


On Tue, 30 Sep 2025 22:54:48 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add assert for _id_counter == 0
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 2608:
> 
>> 2606:     // id_counter overflow
>> 2607:     return nullptr;
>> 2608:   }
> 
> I think it will cause issue with `ubsan` because we don't check for `nullptr` returned from this method.
> May be use `guarantee(id > 0);` instead ?
> 
> 2^32 -1 is big number. We can't have so much method's signatures combinations.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27553#discussion_r2399767124


More information about the hotspot-dev mailing list