RFR: 8369190: JavaFrameAnchor on AArch64 has unnecessary barriers and wrong store order in MacroAssembler [v3]
Andrew Haley
aph at openjdk.org
Mon Oct 6 16:35:25 UTC 2025
On Mon, 6 Oct 2025 16:31:44 GMT, Justin King <jcking at openjdk.org> wrote:
>> Remove unnecessary release barriers in `JavaFrameAnchor::{copy,clear}` and fix `MacroAssembler::set_last_Java_frame` to set `sp` last as expected by the profiler.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove barriers and just fix program order for sp store in MacroAssembler
>
> Signed-off-by: Justin King <jcking at google.com>
Thanks. Add a comment to the effect that we don't need a fence because the profiler always reads from the same thread, and we're done.
-------------
PR Review: https://git.openjdk.org/jdk/pull/27645#pullrequestreview-3305856488
More information about the hotspot-dev
mailing list