RFR: 8369190: JavaFrameAnchor on AArch64 has unnecessary barriers and wrong store order in MacroAssembler [v4]

[Andrew Haley]

On Mon, 6 Oct 2025 16:38:51 GMT, Justin King <jcking at openjdk.org> wrote:

>> Remove unnecessary release barriers in `JavaFrameAnchor::{copy,clear}` and fix `MacroAssembler::set_last_Java_frame` to set `sp` last as expected by the profiler.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment to JavaFrameAnchor regarding no need for fencing
>   
>   Signed-off-by: Justin King <jcking at google.com>

Sorry, approval rescinded.

src/hotspot/cpu/aarch64/javaFrameAnchor_aarch64.hpp line 44:

> 42:     // clearing _last_Java_sp must be first
> 43:     _last_Java_sp = nullptr;
> 44:     OrderAccess::release();

You still need a compiler fence here.

-------------

Changes requested by aph (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27645#pullrequestreview-3305952362
PR Review Comment: https://git.openjdk.org/jdk/pull/27645#discussion_r2407395441