RFR: 8357445: G1: Time-Based Heap Uncommit During Idle Periods [v7]
Monica Beckwith
mbeckwit at openjdk.org
Tue Oct 7 21:09:18 UTC 2025
On Tue, 2 Sep 2025 10:01:43 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Monica Beckwith has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove unused static _uncommit_delay member and accessor
>
> src/hotspot/share/gc/g1/g1HeapEvaluationTask.cpp line 37:
>
>> 35:
>> 36: G1HeapEvaluationTask::G1HeapEvaluationTask(G1CollectedHeap* g1h, G1HeapSizingPolicy* heap_sizing_policy) :
>> 37: PeriodicTask(G1TimeBasedEvaluationIntervalMillis), // Use PeriodicTask with interval
>
> Periodic tasks do not have a flexible interval. So making `G1TimeBasedEvaluationIntervalMillis` manageable and changing it will have no effect (and `PeriodicTask` does not support changing intervals).
I have changed it to use the G1Service task framework
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26240#discussion_r2411931348
More information about the hotspot-dev
mailing list