RFR: 8369190: JavaFrameAnchor on AArch64 has unnecessary barriers and wrong store order in MacroAssembler [v4]

[Justin King]

On Tue, 7 Oct 2025 21:03:51 GMT, Dean Long <dlong at openjdk.org> wrote:

>>> > I don't think copy() is ever called. Can we remove it?
>>> 
>>> Sure.
>> 
>> Ah no. `copy()` is called after the anchor is constructed.
>
> I missed that because I had commented out the JavaFrameAnchor(JavaFrameAnchor *src) ctor, thinking it was the only use, and it still builds.
> 
> I tried to research what this comment is about:
>     // Hack Alert: Temporary bugfix for 4717480/4721647
> and my conclusion is that it seems to be left over from an earlier safepoint implementation where the VM thread could look at the anchor of other threads while they were still running.  I don't think we do that anymore.

Deleted the now defunct comment, I believe you are correct.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27645#discussion_r2413691928