RFR: 8367413: Fix potential truncation error in Arguments::set_heap_size() [v8]

Joel Sikström jsikstro at openjdk.org
Thu Oct 9 08:21:01 UTC 2025


On Wed, 8 Oct 2025 13:11:18 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Joel Sikström has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
>> 
>>  - Merge branch 'master' into JDK-8367413_arguments_sizet_julong
>>  - Rename limit_by_size_t_max to clamp_by_size_t_max
>>  - Make limit_by_size_t_max to a static function in arguments.cpp
>>  - Rename ram_limit_set to has_ram_limit
>>  - Revert MaxRAM default removals, defer to future enhancement
>>  - Namings and comment
>>  - 8367413: Refactor types in Arguments::set_heap_size()
>>  - Merge branch 'master' into JDK-8367413_arguments_sizet_julong
>>  - Revert "8367413: Use size_t instead of julong in runtime/arguments.cpp"
>>    
>>    This reverts commit 35c6057a4b5f0e478f3e703f6fa14b137cd73ca8.
>>  - Revert "size_t casts for 32-bit part of test_arguments.cpp"
>>    
>>    This reverts commit dba2ab4699b9295ba406abf174a7829600ce8625.
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/23fcbb0b...f5649cb7
>
> Marked as reviewed by ayang (Reviewer).

For sanity I reran tier1-4, which looks good. Thank you for the reviews @albertnetymk and @lkorinth.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27224#issuecomment-3384683108


More information about the hotspot-dev mailing list