RFR: 8369186: HotSpot Style Guide should permit some uses of the C++ Standard Library [v2]
Kim Barrett
kbarrett at openjdk.org
Thu Oct 9 08:40:32 UTC 2025
On Wed, 8 Oct 2025 13:23:09 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> src/hotspot/share/utilities/tuple.hpp line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2023, 2025, Oracle and/or its affiliates. All rights reserved.
>>
>> So we have our own tuple ...
>
> We have our own baby partial tuple. What's there is more like a heterogeneous
> array with compile-time indexing. It's used for one thing, and provides just
> enough functionality for that use. I'm not entirely convinced it's the right
> tool for the job, though I haven't taken the time to work out alternatives.
I looked at the use of Tuple<...>. I think using named structs with named
members would be an improvement. Eliminates questions like is src element 0
and dst element 1, or is it the other way around.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27601#discussion_r2416001474
More information about the hotspot-dev
mailing list