RFR: 8307495: Specialize atomic bitset functions for aix-ppc [v6]
Martin Doerr
mdoerr at openjdk.org
Fri Oct 10 09:20:07 UTC 2025
On Fri, 10 Oct 2025 08:02:06 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> David Briemann has updated the pull request incrementally with one additional commit since the last revision:
>>
>> cast compare_value to unsigned
>
> src/hotspot/cpu/ppc/atomicAccess_ppc.hpp line 186:
>
>> 184: : [dest] "b" (dest),
>> 185: [exchange_value] "r" (exchange_value),
>> 186: "m" (*dest)
>
> The memory operands with constraint 'm' are unused. I think the intent was to express that `dest` is dereferenced to read and write memory at that location. But that's expressed with `memory` in the `clobber` section.
> These operands should be removed.
Do you know what "b" means? We use "r" at other places.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27650#discussion_r2419037761
More information about the hotspot-dev
mailing list