RFR: 8369296: Add fast class init checks in interpreter for resolving ConstantPool entries for static field [v9]

Martin Doerr mdoerr at openjdk.org
Fri Oct 10 16:14:15 UTC 2025


On Fri, 10 Oct 2025 14:34:40 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> This patch adds fast clinit barrier in the interpreter when resolving cp entry for a static field.
>> 
>> Testing: tested x86-64 by running `hotspot_runtime` group
>> Specifically, `runtime/clinit/ClassInitBarrier.java` fails if the block for adding `clinit_barrier` is commented out in `TemplateTable::resolve_cache_and_index_for_field`
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert ppc64 changes
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

Thank you for improving it for all platforms! I think it is better readably, now. Only a minor nit. We'll retest it over the weekend.

src/hotspot/cpu/ppc/templateTable_ppc_64.cpp line 2204:

> 2202: 
> 2203: 
> 2204: 

Can you remove these extra empty lines, please?

-------------

PR Review: https://git.openjdk.org/jdk/pull/27676#pullrequestreview-3324544743
PR Review Comment: https://git.openjdk.org/jdk/pull/27676#discussion_r2421055636


More information about the hotspot-dev mailing list