RFR: 8368897: RISC-V: Cleanup RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS [v4]

[Hamlin Li]

On Mon, 6 Oct 2025 15:55:36 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>>> Hey, I don't get the premise.
>>> 
>>> VMVersion have a bunch of methods e.g VM_Version::supports_data_cache_line_flush() / VM_Version::get_current_sve_vector_length, etc.... Now we call some of them "non_ext_UnalignedScalar()", why ? And how is this a improvement ?
>>> 
>>> VM_Version methods is not related to whatever or not some information we need is part of an RVI extension.
>>> 
>>> E.g. VMVersion::unaligned_scalar() (hotspot don't do camel case) seems more reasonable.
>> 
>> I don't have a preference to the name, either `unaligned_scalar` or `non_ext_UnalignedScalar`. Let's see how others think about it, then I'll modify accordingly.
>
>> > Hey, I don't get the premise.
>> > VMVersion have a bunch of methods e.g VM_Version::supports_data_cache_line_flush() / VM_Version::get_current_sve_vector_length, etc.... Now we call some of them "non_ext_UnalignedScalar()", why ? And how is this a improvement ?
>> > VM_Version methods is not related to whatever or not some information we need is part of an RVI extension.
>> > E.g. VMVersion::unaligned_scalar() (hotspot don't do camel case) seems more reasonable.
>> 
>> I don't have a preference to the name, either `unaligned_scalar` or `non_ext_UnalignedScalar`. Let's see how others think about it, then I'll modify accordingly.
> 
> 
> Camel case is not an opinion: "and function names are lower-case (foo_bar). (For these, avoid mixing in upper case letters.)"
> https://wiki.openjdk.org/display/HotSpot/StyleGuide#StyleGuide-Names
> See e.g. : https://github.com/openjdk/jdk/blob/b6a4cfecb731615b6ef70828ac10fae4b2264cdc/src/hotspot/share/runtime/abstract_vm_version.hpp

@robehn Can you have another look? Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27562#issuecomment-3396348983