Integrated: 8368897: RISC-V: Cleanup RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS
Hamlin Li
mli at openjdk.org
Mon Oct 13 10:36:20 UTC 2025
On Mon, 29 Sep 2025 21:37:49 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review the patch?
>
> This patch cleans up RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS, as discussed https://github.com/openjdk/jdk/pull/27152#discussion_r2367109820:
> * reorder flags in alphabetic order for RV_EXT_FEATURE_FLAGS
> * move comments close to feature declaration for RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS
>
> We also discussed (https://github.com/openjdk/jdk/pull/27171#discussion_r2387195562) the assert introduced in https://github.com/openjdk/jdk/pull/24094, previously we think this will restrict the flags order in RV_EXT_FEATURE_FLAGS, but I found out that this assert (<del>is not necessary</del>, so we should be able to order flags in RV_EXT_FEATURE_FLAGS in any way we'd like to) does not work as expected, will fix this in another pr.
>
> Thanks!
This pull request has now been integrated.
Changeset: 28460ca3
Author: Hamlin Li <mli at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/28460ca3305a444238e6edcc80e335be20356e6d
Stats: 168 lines in 4 files changed: 42 ins; 46 del; 80 mod
8368897: RISC-V: Cleanup RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS
Reviewed-by: fyang, rehn
-------------
PR: https://git.openjdk.org/jdk/pull/27562
More information about the hotspot-dev
mailing list