RFR: 8351595: JVM_FindClassFromCaller: unused var may be removed [v2]

David Holmes dholmes at openjdk.org
Tue Oct 14 02:21:03 UTC 2025


On Mon, 13 Oct 2025 20:34:20 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Trivial change to remove an unused line of code. Verified with tier1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unused argument

Renaming etc looks good - thanks. I had assumed this was one of a number of `FindClassXX` methods and so would disappear, but now see it is the primary method and it is just the name and arg that were no longer appropriate.

src/hotspot/share/prims/jvm.cpp line 802:

> 800: JVM_END
> 801: 
> 802: // Find a class with this name in this loader

Suggestion:

// Find a class with this name in this loader.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27735#pullrequestreview-3333662017
PR Review Comment: https://git.openjdk.org/jdk/pull/27735#discussion_r2427736161


More information about the hotspot-dev mailing list