RFR: 8368950: RISC-V: fail to catch out of order declarations among dependent cpu extensions/flags [v2]
Fei Yang
fyang at openjdk.org
Tue Oct 14 12:13:06 UTC 2025
On Tue, 14 Oct 2025 10:06:21 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> I see what you mean.
>> I have a another idea. As these dependency checks are only used in extension related scenarios (ie. RVExtFeatureValue), how about we move all these things into RVExtFeatureValue, including `dependent_index`, `deps_all_enabled`, `deps_string` and `verify_deps`?
>
> please have a look at the second commit, currently only RVExtFeatureValue needs a (cpu) feature index and depenecny checks, so seems it's better to keep it inside RVExtFeatureValue. let me know how you think about it.
That make sense to me. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27572#discussion_r2428925110
More information about the hotspot-dev
mailing list