RFR: 8368950: RISC-V: fail to catch out of order declarations among dependent cpu extensions/flags [v2]

Hamlin Li mli at openjdk.org
Tue Oct 14 12:41:55 UTC 2025


On Tue, 14 Oct 2025 11:56:13 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - move dependency checks into RVExtFeatureValue
>>  - only verify_deps when debug
>
> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 130:
> 
>> 128:       _cpu_feature_index(cpu_feature_index) {
>> 129:     }
>> 130:     int dependent_index() {
> 
> Or simply `feature_index`? Or `cpu_feature_index`? This is also used for other purpose like in AOT support.

make sense, will modify it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27572#discussion_r2429014158


More information about the hotspot-dev mailing list