RFR: 8368950: RISC-V: fail to catch out of order declarations among dependent cpu extensions/flags [v2]
Hamlin Li
mli at openjdk.org
Tue Oct 14 15:22:07 UTC 2025
On Tue, 14 Oct 2025 14:09:09 GMT, Fei Yang <fyang at openjdk.org> wrote:
> Here is what I am thinking: Your `verify_deps` only ensures that the declarations of the extensions are in the correct order (as indicated by the `_cpu_feature_index`). And that is the order in which we should follow when enabling these extensions. So for this to work, the order should be refected by `RiscvHwprobe::add_features_from_query_result` which does the work. For safety, I think we should always sync them. Make sense?
OK, I'll reorder it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27572#issuecomment-3402377615
More information about the hotspot-dev
mailing list