RFR: 8369685: RISC-V: refactor code related to RVFeatureValue::enabled
Robbin Ehn
rehn at openjdk.org
Wed Oct 15 06:11:03 UTC 2025
On Mon, 13 Oct 2025 13:02:50 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this patch?
> @RealFYang
>
> Original discussion is here: https://github.com/openjdk/jdk/pull/27562#discussion_r2415984981.
> Although seems we can not remove it, but we can still remove some of the redundant check like `mvendorid.enabled()`.
> And also do some simple refactoring related to enable/disable/enabled and so on.
>
> Thanks
src/hotspot/cpu/riscv/vm_version_riscv.cpp line 110:
> 108: if (mvendorid.value() == RIVOS) {
> 109: if (FLAG_IS_DEFAULT(UseConservativeFence)) {
> 110: FLAG_SET_DEFAULT(UseConservativeFence, false);
I change UseConservativeFence default to false, but I forgot to remove this.
So you can just remove this part instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27771#discussion_r2431220709
More information about the hotspot-dev
mailing list