RFR: 8368950: RISC-V: fail to catch out of order declarations among dependent cpu extensions/flags [v4]

[Hamlin Li]

On Wed, 15 Oct 2025 02:20:35 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 19 additional commits since the last revision:
>> 
>>  - reorder
>>  - Merge branch 'master' into fix-out-of-order-declarations
>>  - Merge branch 'openjdk:master' into master
>>  - Merge branch 'openjdk:master' into master
>>  - Merge branch 'openjdk:master' into master
>>  - rename
>>  - move dependency checks into RVExtFeatureValue
>>  - only verify_deps when debug
>>  - initial commit
>>  - initial commit
>>  - ... and 9 more: https://git.openjdk.org/jdk/compare/7f9bbe17...d8f39f70
>
> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 175:
> 
>> 173:     }
>> 174: 
>> 175: #ifndef PRODUCT
> 
> Nit: can we switch to use `#ifdef ASSERT` instead in order to better match `DEBUG_ONLY` at the use site?
> 
> 
>  #ifdef ASSERT
>  #define DEBUG_ONLY(code) code
>  #define NOT_DEBUG(code)
>  #define NOT_DEBUG_RETURN  /*next token must be ;*/
>  #else // ASSERT
>  #define DEBUG_ONLY(code)
>  #define NOT_DEBUG(code) code
>  #define NOT_DEBUG_RETURN {}
>  #endif // ASSERT

sure, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27572#discussion_r2431552745