RFR: 8369569: Rename methods in regmask.hpp to conform with HotSpot coding style

Antón Seoane Ampudia duke at openjdk.org
Wed Oct 15 09:07:52 UTC 2025


On Wed, 15 Oct 2025 08:14:26 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

> A number of methods in regmask.hpp do not conform with the HotSpot coding style. We should make sure they do.
> 
> ### Changeset
> - Rename methods in `regmask.hpp` to conform with HotSpot coding style.
> - Similarly rename directly related methods in `chaitin.hpp`.
> - Rename the constant register masks `All` and `Empty` to `ALL` and `EMPTY`.
> - Fix a few additional code style issues at lines touched by the changeset.
> 
> Note: this is a syntax-only changeset (no functional changes).
> 
> ### Testing
> 
> - [GitHub Actions](https://github.com/dlunde/jdk/actions/runs/18500704336)
> - `tier1` and HotSpot parts of `tier2` and `tier3` (and additional Oracle-internal testing) on Windows x64, Linux x64, Linux aarch64, macOS x64, and macOS aarch64.

Marked as reviewed by anton-seoane at github.com (no known OpenJDK username).

Looks good!

-------------

PR Review: https://git.openjdk.org/jdk/pull/27817#pullrequestreview-3339236292
PR Comment: https://git.openjdk.org/jdk/pull/27817#issuecomment-3405337479


More information about the hotspot-dev mailing list