RFR: 8361451: Test vmTestbase/metaspace/stressHierarchy/stressHierarchy012/TestDescription.java fails with OutOfMemoryError: Metaspace [v2]
Coleen Phillimore
coleenp at openjdk.org
Tue Oct 21 13:57:30 UTC 2025
On Tue, 21 Oct 2025 01:49:08 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix cut/paste errors.
>
> test/hotspot/jtreg/vmTestbase/metaspace/stressHierarchy/common/PerformChecksHelper.java line 140:
>
>> 138: }
>> 139: } catch (InvocationTargetException ite) {
>> 140: if (ite.getCause() != null && ite.getCause().getMessage().trim().toLowerCase().contains("Metaspace")) {
>
> Surely this can never be true as you converted to lowercase and are searching for uppercase 'M'. ??
>
> And the `trim()` serves no purpose that I can see when you are using `contains`.
I think I did a bit too much cut/paste without reading it. fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27907#discussion_r2448426452
More information about the hotspot-dev
mailing list