RFR: 8369211: AArch64: Devirtualize class RelocActions [v2]
Andrew Dinn
adinn at openjdk.org
Tue Oct 21 14:09:27 UTC 2025
On Thu, 16 Oct 2025 15:52:09 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> RelocActions is instantiated every time we need to apply a reloc. There's really no need for this, and the use of virtual member functions and function pointers obfuscates the code.
>>
>> While C++ compilers can devirtualize much of this, they don't always devirtualize all of it. Let's make RelocActions all static.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>
> remove the two parameter versions of MacroAssembler::target_addr_for_insn
Still good.
-------------
Marked as reviewed by adinn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27649#pullrequestreview-3361003522
More information about the hotspot-dev
mailing list