RFR: 8334866: Improve Speed of ElfDecoder source search [v4]

Kerem Kat krk at openjdk.org
Fri Oct 24 14:30:58 UTC 2025


On Wed, 22 Oct 2025 13:04:27 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Kerem Kat has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into elfdecoder-JDK-8334866
>>  - Merge remote-tracking branch 'upstream/master' into elfdecoder-JDK-8334866
>>  - Merge remote-tracking branch 'upstream/master' into elfdecoder-JDK-8334866
>>  - 8334866: Cache debug_aranges for faster address lookups
>
> src/hotspot/share/utilities/elfFile.hpp line 551:
> 
>> 549:     void sort() {
>> 550:       qsort(_entries, _count, sizeof(ArangesEntry), DwarfFile::ArangesCache::compare_aranges_entries);
>> 551:     }
> 
> [drive-by comment] Use of qsort is questionable.  See https://bugs.openjdk.org/browse/JDK-8248137

Using `QuickSort::sort` instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27337#discussion_r2460772290


More information about the hotspot-dev mailing list