RFR: 8347463: jdk/jfr/threading/TestManyVirtualThreads.java crashes with assert(oopDesc::is_oop_or_null(val)) [v5]
Anton Seoane Ampudia
aseoane at openjdk.org
Mon Oct 27 10:49:53 UTC 2025
On Mon, 27 Oct 2025 10:32:34 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> Anton Seoane Ampudia has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Apply review comments
>
> test/hotspot/jtreg/compiler/intrinsics/TestReturnsOopSetForJFRWriteCheckpoint.java line 55:
>
>> 53: @Test
>> 54: @IR(counts = { IRNode.STATIC_CALL_OF_METHOD, "write_checkpoint\s+java/lang/Object\s+\\*", "1" })
>> 55: public void myTest() {
>
> Maybe use a more descriptive name than `myTest`, for example summarizing the effect of the test (`testStartRecordingAndEmitEvent`) or its intent (`testWriteCheckpointReturnType`).
For sure. I don't know how I forgot to change such a placeholder name... I have gone for the latter suggestion
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27913#discussion_r2465189899
More information about the hotspot-dev
mailing list