RFR: 8334898: Resolve static field/method references at CDS dump time [v3]
Ashutosh Mehra
asmehra at openjdk.org
Mon Oct 27 13:45:50 UTC 2025
On Mon, 27 Oct 2025 13:39:29 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Move check for VM_Version::supports_fast_class_init_checks() to
>> remove_resolved_method_entries_if_non_deterministic()
>>
>> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> src/hotspot/share/oops/cpCache.cpp line 498:
>
>> 496: (rme->is_resolved(Bytecodes::_invokestatic) ? " *** static" : ""));
>> 497: }
>> 498: ArchiveBuilder::alloc_stats()->record_method_cp_entry(archived, resolved && !archived);
>
> It certainly looks right to move this outside the test for logging being enabled but does it make any practical difference i.e.is the statistic used for anything other than this logging category?
Nope, I don't it affects anything other than the stats for logging. I think this was just a bug.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27958#discussion_r2465732322
More information about the hotspot-dev
mailing list