RFR: 8367982: Unify ObjectSynchronizer and LightweightSynchronizer [v2]
Coleen Phillimore
coleenp at openjdk.org
Mon Oct 27 21:51:08 UTC 2025
On Fri, 24 Oct 2025 13:56:31 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:
>> src/hotspot/share/runtime/synchronizer.inline.hpp line 40:
>>
>>> 38: return read_monitor(mark);
>>> 39: } else {
>>> 40: return ObjectSynchronizer::get_monitor_from_table(current, obj);
>>
>> I don't think there's a need for this file anymore. read_monitor is mostly called inside synchronizer.cpp, so it can be inlined there.
>
> Would you want me to do that in this PR? Or should I create a new RFE for that, just to acknowledge the fact that one should never say "last" cleanup. :)
I think this should change with this PR. The big reason synchronizer.inline.hpp was added was to have this inlining based on LockingMode, which we don't need anymore.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27915#discussion_r2467164531
More information about the hotspot-dev
mailing list