RFR: 8351159: Remaining cleanups in cpu/x86 after 32-bit x86 removal [v2]

Anton Seoane Ampudia aseoane at openjdk.org
Tue Oct 28 09:06:29 UTC 2025


On Mon, 27 Oct 2025 09:06:02 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Anton Seoane Ampudia has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply review comments
>
> src/hotspot/cpu/x86/frame_x86.hpp line 83:
> 
>> 81: 
>> 82:     // Entry frames
>> 83: #ifdef AMD64
> 
> Did you consider if `_WIN64` could be replaced with _WINDOWS?

I had missed it. In this context, it can

> src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp line 163:
> 
>> 161: }
>> 162: 
>> 163: #if defined(_WINDOWS)
> 
> Do we really need to check for `_WINDOWS` in a windows file?

We don't. Fixed it

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27987#discussion_r2468579337
PR Review Comment: https://git.openjdk.org/jdk/pull/27987#discussion_r2468584644


More information about the hotspot-dev mailing list