Integrated: 8366488: JVM_FindClassFromClass should assert that from class is never null
Paul Hübner
phubner at openjdk.org
Tue Oct 28 16:50:58 UTC 2025
On Thu, 23 Oct 2025 15:55:41 GMT, Paul Hübner <phubner at openjdk.org> wrote:
> Hi all,
>
> The `from_class` nullcheck in `JVM_FindClassFromClass` is redundant, as the this is the Java mirror which cannot be null during class linking/verification [1]. Therefore, it has been refactored to be an assertion instead.
>
> Testing: tiers 1-4 Linux (x64, AArch64), macOS (x64, AArch64), Windows (x64). As part of a separate experiment, I've also run tiers 1-6 on x64 Linux with a non-null assertion before we call `Verifier::inference_verify` (which in turn, eventually, calls this code).
>
> [1] For reasoning, see https://bugs.openjdk.org/browse/JDK-8366488
This pull request has now been integrated.
Changeset: 289f421f
Author: Paul Hübner <phubner at openjdk.org>
Committer: Coleen Phillimore <coleenp at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/289f421f0f132685c2bd0e6cbc702040e067184e
Stats: 7 lines in 1 file changed: 0 ins; 2 del; 5 mod
8366488: JVM_FindClassFromClass should assert that from class is never null
Reviewed-by: coleenp, dholmes
-------------
PR: https://git.openjdk.org/jdk/pull/27957
More information about the hotspot-dev
mailing list