RFR: 8351149: Remove dead IA32/X32/!AMD64 code blocks after 32-bit x86 removal [v2]

Vladimir Kozlov kvn at openjdk.org
Tue Oct 28 17:52:42 UTC 2025


On Tue, 28 Oct 2025 11:36:44 GMT, Anton Seoane Ampudia <aseoane at openjdk.org> wrote:

>> This PR carries out cleanup of `IA32`-, `X32`- and `!AMD64`-guarded code blocks after the removal of the 32-bit x86 architecture from HotSpot.
>> 
>> These code blocks are either not needed anymore or the guards redundant.
>> 
>> Please note that this changeset addresses the "complement" of [JDK-8351159](https://github.com/openjdk/jdk/pull/27987). This is to say, this PR targets all directories that are *not* `cpu/x86` and `os_cpu/x86`.
>> 
>> **Testing:** passes tiers 1-3
>
> Anton Seoane Ampudia has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply review comments (restore mistakenly cleaned define)

Good.

src/hotspot/share/c1/c1_CodeStubs.hpp line 141:

> 139:   ConversionStub(Bytecodes::Code bytecode, LIR_Opr input, LIR_Opr result)
> 140:     : _bytecode(bytecode), _input(input), _result(result) {
> 141:     ShouldNotReachHere();

Should we remove this code then in separate RFE?

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27990#pullrequestreview-3390086571
PR Review Comment: https://git.openjdk.org/jdk/pull/27990#discussion_r2470503030


More information about the hotspot-dev mailing list