RFR: 8359359: AArch64: share trampolines between static calls to the same method [v6]

Mikhail Ablakatov mablakatov at openjdk.org
Wed Oct 29 17:58:23 UTC 2025


On Thu, 9 Oct 2025 16:57:35 GMT, Mikhail Ablakatov <mablakatov at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 908:
>> 
>>> 906:       // code during its branch shortening phase.
>>> 907:       if (entry.rspec().type() == relocInfo::runtime_call_type) {
>>> 908:         assert(CodeBuffer::supports_shared_stubs(), "must support shared stubs");
>> 
>> `assert(callee == nullptr, "Runtime calls must not have Method");`
>
> Sure, this shouldn't be a problem, thanks.

Done, see https://github.com/openjdk/jdk/pull/25954/commits/27518a0ff21723c45fcdee3c2730285cc0580c95

>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 1339:
>> 
>>> 1337:   // Trampolines may be emitted immediately or deferred until stub finalization,
>>> 1338:   // enabling reuse across call sites to reduce code size.
>>> 1339:   // Runtime call trampolines are shared based on the entry value.
>> 
>> ... on entry value -> ... on entry target
>
> Here "value" is used as a "value of a parameter". I'll rephrase it so it's less ambiguous , thanks.

Done, see https://github.com/openjdk/jdk/pull/25954/commits/162754b719b40e6d5d3dc9185772e032fd327fa2

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25954#discussion_r2474409559
PR Review Comment: https://git.openjdk.org/jdk/pull/25954#discussion_r2474407689


More information about the hotspot-dev mailing list