RFR: 8369238: Allow virtual thread preemption on some common class initialization paths [v3]
David Holmes
dholmes at openjdk.org
Thu Oct 30 06:26:06 UTC 2025
On Wed, 29 Oct 2025 20:34:24 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> I don't think we would have to. There are a handful of methods that now declare TRAPS but the only exception they should ever encounter is the PreemptException. It would be easier to understand the code if this was evident in their use of TRAPS. Also note it is purely documentation - the definition of `PREEMPTABLE_TRAPS` is exactly the same as `TRAPS`
>
> If we want to avoid confusion with other users of `ObjectLocker` maybe we can leave it as it is and subclass it with a preemptable version? https://github.com/pchilano/jdk/compare/JDK-8369238...pchilano:jdk:PreemptableObjectLocker (this version could also use `PREEMPTABLE_TRAPS`)
Never mind - I thought there were a few functions that had TRAPS added just for the preempt case but now I don't see them. Thanks
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27802#discussion_r2476548285
More information about the hotspot-dev
mailing list