RFR: 8334866: Improve Speed of ElfDecoder source search [v8]
Kerem Kat
krk at openjdk.org
Thu Oct 30 11:46:20 UTC 2025
On Thu, 30 Oct 2025 11:35:06 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Kerem Kat has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Revert "Erase obsolete comments"
>>
>> This reverts commit 860b6ee6faeb6e56e292abef1c85faad456729e2.
>> - fix space
>> - Erase obsolete comments
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebugger.java line 52:
>
>> 50: public WindbgOopHandle readOopHandle(long address) throws DebuggerException;
>> 51: public WindbgOopHandle readCompOopHandle(long address) throws DebuggerException;
>> 52:
>
> This commit just happened while I reviewed the old state. Can you explain why you want to squeeze this and the cleanup below in here? It does not seem to be related to improving the DWARF parser. If it's unrelated, you could still clean it up but might be better done separately.
You caught it quickly, this was meant for another PR. Sorry for the spam.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27337#discussion_r2477745065
More information about the hotspot-dev
mailing list