RFR: 8367982: Unify ObjectSynchronizer and LightweightSynchronizer [v3]
Fredrik Bredberg
fbredberg at openjdk.org
Fri Oct 31 14:33:09 UTC 2025
On Fri, 31 Oct 2025 14:02:20 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:
>> This is the last PR in a series of PRs (see: [JDK-8344261](https://bugs.openjdk.org/browse/JDK-8344261)) to obsolete the LockingMode flag and related code.
>>
>> The main focus is to to unify `ObjectSynchronizer` and `LightweightSynchronizer`.
>> There used to be a number of "dispatch functions" to redirect calls depending on the setting of the `LockingMode` flag.
>> Since we now only have lightweight locking, there is no longer any need for those dispatch functions, so I removed them.
>> To remove the dispatch functions I renamed the corresponding lightweight functions and call them directly.
>> This ultimately led me to remove "lightweight" from the function names and go back to "fast" instead, just to avoid having some with, and some without the "lightweight" part of the name.
>>
>> This PR also include a small simplification of `ObjectSynchronizer::FastHashCode`.
>>
>> Tested tier1-7 (on supported platforms) without seeing any problems that can be traced to this code change.
>> All other platforms (`arm`, `ppc`, `riscv`, `s390`) has been sanity checked using QEMU.
>
> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>
> Update two, after the review
Unfortunately I have no time to fix the merge conflict before the weekend. :(
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27915#issuecomment-3473351963
More information about the hotspot-dev
mailing list